✨ Added more social accounts to staff profiles

[ErisDS]

ref https://linear.app/ghost/issue/PLG-418/promote-social-links-feature-to-ga

• This feature adds 7 new social accounts to staff profiles
• And a new {{social_url}} helper for outputting them in themes

[coderabbitai]

Walkthrough

The changes include two main updates. First, the 'socialLinks' feature flag is moved from the ALPHA_FEATURES array to the GA_FEATURES array, reclassifying it from an experimental feature to a generally available feature that is always enabled by default and in tests. Second, in the end-to-end API tests for the admin settings, the 'content-length': anyContentLength header matcher is added to the .matchHeaderSnapshot() calls within the "Can edit a setting" test case. This addition ensures that the content-length header is explicitly verified in the response headers snapshot. No other logic, error handling, or changes to exported or public entities are introduced.

Suggested labels

migration

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ce004940c46038f34cf43aba0fb25c721d523a8 and 46ed2ed.

⛔ Files ignored due to path filters (1)

• ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap is excluded by !**/*.snap

📒 Files selected for processing (2)

• ghost/core/core/shared/labs.js (2 hunks)
• ghost/core/test/e2e-api/admin/settings.test.js (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• ghost/core/core/shared/labs.js

⏰ Context from checks skipped due to timeout of 90000ms (12)

• GitHub Check: Browser tests
• GitHub Check: Ghost-CLI tests
• GitHub Check: Database tests (Node 20.11.1, sqlite3)
• GitHub Check: Regression tests (Node 20.11.1, sqlite3)
• GitHub Check: Database tests (Node 22.13.1, mysql8)
• GitHub Check: Database tests (Node 20.11.1, mysql8)
• GitHub Check: Regression tests (Node 20.11.1, mysql8)
• GitHub Check: Database tests (Node 18.12.1, mysql8)
• GitHub Check: Unit tests (Node 22.13.1)
• GitHub Check: Unit tests (Node 20.11.1)
• GitHub Check: Unit tests (Node 18.12.1)
• GitHub Check: Lint

🔇 Additional comments (1)

ghost/core/test/e2e-api/admin/settings.test.js (1)

193-197: LGTM! Consistent with existing patterns.

This addition of the 'content-length': anyContentLength header matcher is consistent with the pattern used throughout the file for other tests. It ensures that the content-length header is explicitly verified in the response headers snapshot while allowing for flexibility as content changes when the 'socialLinks' feature moves from alpha to GA status.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.