Hid color swatches unless color picker is expanded

[sanne-san]

Ref https://linear.app/ghost/issue/PROD-1865/improve-color-picker-component

• In favour of a calmer UI, we only show the color swatches when the color picker is expanded

[coderabbitai]

Walkthrough

The logic in the ColorIndicator.tsx component was updated to simplify how the selectedSwatch is determined, removing a conditional reset tied to the isExpanded state. Now, selectedSwatch consistently refers to the first swatch matching the current value or hex. The swatch list is now rendered only when isExpanded is true, instead of being rendered unconditionally. Additionally, the color preview in the picker button is always shown when value is truthy, using the selectedSwatch hex if available, otherwise defaulting to value. The transparent color indicator within the preview remains unchanged.

Possibly related PRs

• Added bg color to newsletter design settings #23084: Adjusts border color CSS classes in ColorIndicator.tsx, affecting styles rather than rendering logic, but operates on the same component as this PR.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/admin-x-design-system/src/global/form/ColorIndicator.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "/apps/admin-x-design-system".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in "apps/admin-x-design-system/.eslintrc.cjs".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 072f956 and 969b002.

📒 Files selected for processing (1)

• apps/admin-x-design-system/src/global/form/ColorIndicator.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Unit tests (Node 20.11.1)
• GitHub Check: Admin-X Settings tests
• GitHub Check: Unit tests (Node 22.13.1)

🔇 Additional comments (3)

apps/admin-x-design-system/src/global/form/ColorIndicator.tsx (3)

75-75: Good simplification of the selectedSwatch logic.

This change streamlines how the selected swatch is determined, making it more consistent by always finding the first swatch that matches either its value or hex with the current value.

---

85-91: Perfect implementation of the PR objective.

This conditional rendering successfully hides the color swatches when the picker isn't expanded, creating a cleaner and less cluttered UI. The use of the logical AND operator is an efficient React pattern for this purpose.

---

95-96: Good improvement to color preview logic.

The color preview now consistently shows when a value exists, using the selectedSwatch hex if available or falling back to the raw value. This provides better visual feedback regardless of whether the selected color matches a predefined swatch.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.