Replaced default user image for navbar #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced default user image for navbar closes #700 - Replaced photo of John (sorry, man) with a smaller version of the default heart user photo
ErisDS
added a commit
that referenced
this pull request
Sep 13, 2013
Replaced default user image for navbar
kevinansfield
pushed a commit
that referenced
this pull request
May 27, 2025
refs TryGhost/Product#3365 - in kg-default-nodes: - added a generator function to generate the boilerplate code inside kg-default-nodes. This method should generate all required base methods from on a set of data properties, but still allow methods to be overwritten by individual nodes - updated getter & setters to use ES6 syntax (getter: node.content, setter: node.content = 'newValue' - added missing tests for urlTransformMap, clone, getType methods for each node - removed INSERT_X_COMMAND - transformed parsers to functional components - used abstracted renderEmptyContainer() utility function in relevant renderers - in koenig-lexical: - created INSERT_X_COMMAND directly - removed duplicated createDOM, updateDOM - updated getters and setters with ES6 syntax - splited functional and class component in old cards, using the MyNode.jsx / MyNodeComponent.jsx existing pattern
kevinansfield
pushed a commit
that referenced
this pull request
May 28, 2025
refs TryGhost/Product#3365 - in kg-default-nodes: - added a generator function to generate the boilerplate code inside kg-default-nodes. This method should generate all required base methods from on a set of data properties, but still allow methods to be overwritten by individual nodes - updated getter & setters to use ES6 syntax (getter: node.content, setter: node.content = 'newValue' - added missing tests for urlTransformMap, clone, getType methods for each node - removed INSERT_X_COMMAND - transformed parsers to functional components - used abstracted renderEmptyContainer() utility function in relevant renderers - in koenig-lexical: - created INSERT_X_COMMAND directly - removed duplicated createDOM, updateDOM - updated getters and setters with ES6 syntax - splited functional and class component in old cards, using the MyNode.jsx / MyNodeComponent.jsx existing pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced default user image for navbar
closes #700