Skip to content

example: slack modal form #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Conversation

etrex
Copy link
Contributor

@etrex etrex commented Jul 3, 2020

add a example for slack modal form

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2020

Codecov Report

Merging #828 into release/1.5 will increase coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.5     #828      +/-   ##
===============================================
+ Coverage        83.23%   83.95%   +0.72%     
===============================================
  Files              108      120      +12     
  Lines             5647     6194     +547     
  Branches          1367     1536     +169     
===============================================
+ Hits              4700     5200     +500     
- Misses             924      990      +66     
+ Partials            23        4      -19     
Impacted Files Coverage Δ
...ckages/bottender/src/messenger/MessengerContext.ts 83.72% <0.00%> (-12.60%) ⬇️
packages/bottender/src/cli/providers/sh/start.ts 25.00% <0.00%> (-11.37%) ⬇️
packages/bottender/src/whatsapp/TwilioClient.ts 50.00% <0.00%> (-6.67%) ⬇️
packages/bottender/src/telegram/routes.ts 94.00% <0.00%> (-6.00%) ⬇️
packages/bottender/src/telegram/TelegramEvent.ts 97.50% <0.00%> (-2.50%) ⬇️
packages/bottender-dialogflow/src/index.ts 92.98% <0.00%> (-2.48%) ⬇️
...ckages/bottender/src/whatsapp/WhatsappConnector.ts 93.02% <0.00%> (-2.10%) ⬇️
packages/bottender/src/viber/ViberContext.ts 92.42% <0.00%> (-0.44%) ⬇️
packages/bottender/src/slack/SlackContext.ts 92.30% <0.00%> (-0.29%) ⬇️
packages/bottender/src/chain.ts 86.66% <0.00%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 994961c...8e6b8fb. Read the comment docs.

@chentsulin chentsulin changed the base branch from master to release/1.5 July 6, 2020 02:37
element: {
actionId: 'element',
type: 'datepicker',
initial_date: '2020-07-01',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initialDate

text: 'Cancel',
emoji: true,
},
notify_on_close: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notifyOnClose

element: {
actionId: 'element',
type: 'plain_text_input',
initial_value: '10:00',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initialValue

Copy link
Collaborator

@chentsulin chentsulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keys should be camel case.

@chentsulin chentsulin merged commit 0072b94 into release/1.5 Jul 6, 2020
@chentsulin chentsulin deleted the example-slack-modal-form branch July 6, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants