Intended behavior of check_nosync with local_first and sync_list

[MattofBum]

When doing a local_first sync, what is the intended behavior of check_nosync when a directory containing the .nosync file contains subdirectories? I would expect all of the subdirectories and their files to be excluded as well, but this is not what I'm experiencing. I'm using a sync_list with inclusions and exclusions as well. Looking at the code (

onedrive/src/sync.d

Line 7449 in 92be98f

// Issue #3126 - https://github.com/abraunegg/onedrive/discussions/3126

), there's a lengthy comment about scanning subdirectories in case there is an inclusion rule that includes some stuff within. Is .nosync supposed to be included in this behavior?

[abraunegg]

If .nosync is not being detected when the directory is being scanned, then that sounds like a bug.

Please follow the basic troubleshooting process by building your client from 'master' and replicate your issue. If you can replicate, please provide a verbose debug log via email for analysis.

[MattofBum]

Well, I found my issue and it was a problem with my config file. I had included an extra quote on my check_nosync line:
check_nosync = "true""

It seems like most of the other configure options are verified in some way, so perhaps bools should be too.

I’m not sure my case in particular should be treated as a malformed line or an invalid value.

It matches the configRegex, so if you want it as a malformed line modifying the regex from ctRegex!(^(\w+)\s*=\s*"(.*)"\s*$) to ctRegex!(^(\w+)\s*=\s*"([^"]*)"\s*$) should do the trick.

Verifying that the value of a bool is either “true” or “false” would be useful. Right now, the code just checks for “true”:
setValueBool(key, c.front.dup == "true" ? true : false);
so it won’t catch typos.

I noticed another issue too, but I need to verify if it's in the latest version.