Skip to content

Optimize root domain search through api #6284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

keryfan
Copy link

@keryfan keryfan commented Mar 26, 2025

No description provided.

Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@keryfan
Copy link
Author

keryfan commented Apr 17, 2025

I have read the guide. This PR just adds filtering to root-domains check to speed-up the process, the rest of the code is same.

@Neilpang
Copy link
Member

please follow the dns api test:
https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Any changes to the dns api hook must be verified by the dns api test.

@keryfan
Copy link
Author

keryfan commented May 8, 2025

please follow the dns api test: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Any changes to the dns api hook must be verified by the dns api test.

Please check again - I've updated settings for actions and added corresponding secrets to repo. Then triggered activity by syncing latest changes from repo to fork.

@Neilpang
Copy link
Member

Neilpang commented May 8, 2025

@keryfan
Copy link
Author

keryfan commented May 14, 2025

it's not passing

https://github.com/fornex-com/acme.sh/actions/runs/14908908134

For some reason it fails on the process of creating container for clearlinux:latest, even before starting cert request.
image

But at the same time all tests with different docker images were successful.

I also tried to run acmetest locally and also got error when testing only clearlinux platform on the phase of creation of container itself.

image

@Neilpang
Copy link
Member

please run it again, it should work.

@keryfan
Copy link
Author

keryfan commented May 27, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants