Implement DNS API for Efficientip SOLIDserver #6333
Conversation
|
Welcome |
|
Waiting for feedback. Thanks in advance. |
|
@Neilpang You seem to be one of the rare active maintainer currently. Any chance to see this pull request accepted and merged ? |
|
did you read this comment? Welcome |
|
Hello @Neilpang, I have read and followed the instructions (even closed initial PR created by mistake to the master branch). I did answered the comment you refer to, but I'm not sure what answer you expect. Many thanks for your feedback. kind regards. |
|
The latest dns api test is not passing: |
|
Well I'm surprised, the error in the run you refer is not with the code associated with the PR. I have re-sync my branch with the official repo. All checks are passing: https://github.com/EfficientIP-Labs/acme.sh/actions/runs/14923396036/job/41922851791 @Neilpang, would you be kind to give it a new try ? Kind regards. |
dnsapi/dns_efficientip.sh
Outdated
| export _H2="Authorization: Basic ${EfficientIP_CredsEncoded}" | ||
| else | ||
| TS=$(date +%s) | ||
| Sig=$(printf "%b\n$TS\nPOST\n$baseurlnObject" "${EfficientIP_Token_Secret}" | openssl dgst -sha3-256 | cut -d '=' -f 2 | tr -d ' ') |
There was a problem hiding this comment.
can you not use the openssl here?
you can use the functin _digest
There was a problem hiding this comment.
Well I can indeed, but I would then need to modify the following line in the acme.sh file to include the sha3-256 digest:
_digest() {
...
if [ "$alg" = "sha3-256" ] || [ "$alg" = "sha256" ] || [ "$alg" = "sha1" ] || [ "$alg" = "md5" ]; then
...
Would that be ok ?
|
Proposed changes address your request. All DNS-API-Test are passing in my branch (https://github.com/EfficientIP-Labs/acme.sh/actions/runs/15239890351). |
Implement DNS API for EfficientIP SOLIDserver DNS providers.