Allow option to exclude specific weekdays from total time #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed actions#564 Add support for excluding specific weekdays when calculating elapsed days for stale issues and PRs. This is particularly useful for organizations that want to consider only business days. - Add new `exclude-weekdays` option to specify which days to exclude (0-6, where 0 is Sunday) - Implement weekday exclusion logic in elapsed days calculation - Add tests to verify business days calculation ```yaml - uses: actions/stale@v9 with: days-before-stale: 5 days-before-close: 2 exclude-weekdays: '0,6' # Exclude weekends ```
alpaca-tc
force-pushed
the
add-exclude-weekdays
branch
from
1403262 to
524c3cd
Compare
alpaca-tc
commented
Mar 10, 2025
Comment on lines
+2375
to
+2388
| let elapsedMillis = to.getTime() - from.getTime(); | ||
| if (excludeWeekdays.length > 0) { | ||
| const startOfNextDayFrom = startOfDay(new Date(from.getTime() + DAY)); | ||
| const startOfDayTo = startOfDay(to); | ||
| if (excludeWeekdays.includes(from.getDay())) { | ||
| elapsedMillis -= startOfNextDayFrom.getTime() - from.getTime(); | ||
| } | ||
| if (excludeWeekdays.includes(to.getDay())) { | ||
| elapsedMillis -= to.getTime() - startOfDayTo.getTime(); | ||
| } | ||
| const excludeWeekdaysCount = countWeekdaysBetweenDates(startOfNextDayFrom, startOfDayTo, excludeWeekdays); | ||
| elapsedMillis -= excludeWeekdaysCount * DAY; | ||
| } | ||
| return elapsedMillis; |
There was a problem hiding this comment.
If you don't use options, the existing implementation is used, so even if there are bugs, the impact is minimal. A simple O(N) calculation logic is used. While an O(1) logic could also be possible, it would be a bit more complex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support for excluding specific weekdays when calculating elapsed days for stale issues and PRs. This is particularly useful for organizations that want to consider only business days.
exclude-weekdaysoption to specify which days to exclude (0-6, where 0 is Sunday)Related issue:
Fixed #564
Check list: