-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Normalize API version for SecurePayAu, Simetrik and StripePaymentIntents. #5450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize API version for SecurePayAu, Simetrik and StripePaymentIntents. #5450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you forgot to change the StripePaymentIntents version and you updated the wrong version for Stripe. So for Stripe/StripePaymentIntents its a little bit different than the other gateways. Their version lives in DEFAULT_API_VERSION and this gets passed in the headers through Stripe-Version
.
For version for StripePaymentIntents is DEFAULT_API_VERSION = '2020-08-27'
this is in lib/active_merchant/billing/gateways/stripe_payment_intents.rb. For Stripe is DEFAULT_API_VERSION = '2020-08-27'. StripePaymentIntents inherits from Stripe
Thanks for sharing |
50b49a2
to
de0af2b
Compare
Summary: ------------------------------------------- Normalize API version for SecurePayAu, Simetrik and StripePaymentIntents. Unit Tests: ------------------------------------------- 6247 tests, 81499 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------------------- 809 files inspected, no offenses detected.
af2ca00
to
a9e19c2
Compare
Summary: Normalize API Version
Normalize API version for SecurePayAu, Simetrik and StripePaymentIntents.
Unit Tests:
6247 tests, 81499 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
RuboCop:
809 files inspected, no offenses detected.