Skip to content

Fix Rapyd error on billing address #5472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jherreraa
Copy link
Collaborator

@jherreraa jherreraa commented May 13, 2025

OPPS-397

Summary:

Fix Incorrect Handling of Phone Number in Customer Address Object Leads to Address Validation Errors in Rapyd

Unit Tests:

Finished in 0.067795 seconds.
54 tests, 254 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
796.52 tests/s, 3746.59 assertions/s

Remote Tests:

Finished in 71.616667 seconds.
55 tests, 140 assertions, 18 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
67.2727% passed
0.77 tests/s, 1.95 assertions/s

** Failing tests are not related to change, several payment methods are not available anymore, need to be validated with rapyd support **

Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is a good candidate for a unit test that validates the presence or absence of fields, based on what we expect should happen.

Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions for you.

I also see now we have 2 different methods for handling the address, def address and def add_address. Do you think there is an opportunity to refactor this to consolidate the logic of adding address details in the requests?

@jherreraa jherreraa force-pushed the OPPS-397_Fix_Rapyd_Validation_Error branch 2 times, most recently from 8a4a7c1 to 16dd170 Compare May 15, 2025 14:53
@jherreraa
Copy link
Collaborator Author

I think this change is a good candidate for a unit test that validates the presence or absence of fields, based on what we expect should happen.

Understood! Unit test added

@jherreraa jherreraa requested a review from naashton May 15, 2025 14:55
@jherreraa jherreraa marked this pull request as ready for review May 15, 2025 14:59
@jherreraa jherreraa requested a review from a team May 15, 2025 14:59
@jherreraa jherreraa force-pushed the OPPS-397_Fix_Rapyd_Validation_Error branch from 16dd170 to 9149e16 Compare May 15, 2025 15:05
@jherreraa jherreraa force-pushed the OPPS-397_Fix_Rapyd_Validation_Error branch from 9149e16 to 0d3d012 Compare May 27, 2025 14:45
@jherreraa jherreraa force-pushed the OPPS-397_Fix_Rapyd_Validation_Error branch from 0d3d012 to 8b88d5f Compare May 27, 2025 16:23
@jherreraa jherreraa force-pushed the OPPS-397_Fix_Rapyd_Validation_Error branch from 8b88d5f to 55a7230 Compare May 28, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants