Skip to content

Add support for Fish 4.1.x #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
talios opened this issue Apr 28, 2025 · 1 comment · May be fixed by #1046
Open

Add support for Fish 4.1.x #1045

talios opened this issue Apr 28, 2025 · 1 comment · May be fixed by #1046

Comments

@talios
Copy link

talios commented Apr 28, 2025

As part of Fish 4.1.x, the $__fish_data_dir variable is no longer used, as it's assets are now compiled into the binary (when built via cargo).

This is documented in the CHANGELOG:

https://github.com/fish-shell/fish-shell/blob/master/CHANGELOG.rst#deprecations-and-removed-features

zoxide needs to be updated to optionally use status get-file if available.

A PR is coming.
talios added a commit to talios/zoxide that referenced this issue Apr 28, 2025
@talios
Update zoxide to support Fish 4.1.x
6f94eb5 
This commit updates the fish init script to support the upcoming 4.1.x
release of Fish by using `status get-file`.

Fixes ajeetdsouza#1045
This was referenced Apr 28, 2025
Open
Closed
@talios
Copy link
Author

talios commented Apr 28, 2025

I've tested this with fish, version 4.1.0-alpha0-gb431873ce but not yet tried a regression check with 4.0 or 3.x.

I'll hopefully get a chance to look at that tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update zoxide to support Fish 4.1.x talios/zoxide
1 participant
@talios