Skip to content

Feature: Support git rev-parse #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spacey-sooty opened this issue Mar 27, 2024 · 5 comments
Closed

Feature: Support git rev-parse #398

spacey-sooty opened this issue Mar 27, 2024 · 5 comments

Comments

@spacey-sooty
Copy link

Could be a solution to #397
spacey-sooty added a commit to spacey-sooty/GradleRIO that referenced this issue Mar 27, 2024
@spacey-sooty
start switching to proper gradle way
03c70fa 
- grgit not fully used see ajoberstar/grgit#398
- doesn't fully use tasks properly I don't think
- file needs to be properly set to output dir
@ajoberstar
Copy link
Owner

The resolve API might be the closest to a rev-parse equivalent.

@spacey-sooty
Copy link
Author

Thanks for the prompt response!
I believe this will fix most of the things I am missing without rev-parse but due to not being able to pass in more specific arguments it still misses a few features most notable git rev-parse --is-inside-work-tree which would be the simplest solution to #397 imo

@spacey-sooty
Copy link
Author

I'm also getting an error that resolve is private within Grgit...

@spacey-sooty spacey-sooty mentioned this issue Mar 28, 2024
Closed
@ajoberstar
Copy link
Owner

If you're coming from Java it may require grgit.getResolve().

The default visibility in Groovy is public, so adding it explicitly like in your #398 shouldn't change anything.

@spacey-sooty
Copy link
Author

Ohhb ok that my mistake, thanks!

spacey-sooty added a commit to spacey-sooty/GradleRIO that referenced this issue Mar 28, 2024
@spacey-sooty
start switching to proper gradle way
4718fa4 
- grgit not fully used see ajoberstar/grgit#398
- doesn't fully use tasks properly I don't think
- file needs to be properly set to output dir

revert plugin changes

fix: use gradle output dir

call the thingy
spacey-sooty added a commit to spacey-sooty/GradleRIO that referenced this issue Jun 30, 2024
@spacey-sooty
start switching to proper gradle way
32cbe68 
- grgit not fully used see ajoberstar/grgit#398
- doesn't fully use tasks properly I don't think
- file needs to be properly set to output dir

revert plugin changes

fix: use gradle output dir

call the thingy
@spacey-sooty spacey-sooty closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajoberstar @spacey-sooty