-
Notifications
You must be signed in to change notification settings - Fork 697
Implement AI-image-reader plugin #1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1925 +/- ##
==========================================
+ Coverage 35.91% 44.70% +8.79%
==========================================
Files 69 79 +10
Lines 11576 12753 +1177
==========================================
+ Hits 4157 5701 +1544
+ Misses 7104 6706 -398
- Partials 315 346 +31 🚀 New features to boost your workflow:
|
PTAL, Thanks @johnlanni |
PTAL, thanks @johnlanni |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plugin should not be tightly coupled with the Qwen model; it should be designed with an abstraction layer, treating the Qwen model as one implementation, and also support other OCR models like Mistral
redesigned, PTAL thanks. @johnlanni |
to be reviewed |
| `apiKey` | string | 必填 | - | 用于在访问OCR服务时进行认证的令牌。 | | ||
| `serviceName` | string | 必填 | - | 后端OCR服务名 | | ||
| `servicePort` | int | 必填 | - | 后端OCR服务端口 | | ||
| `model` | string | 必填 | - | 后端OCR服务模型名称(例如qwen) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个model会跟实际使用的model名,例如qwen-vl-ocr混淆,建议还是用 provider 来区分。单独增加一个可以配置的 model 名
Ⅰ. Describe what this PR did
Implement AI-image-reader plugin
Ⅱ. Does this pull request fix one issue?
fixes #1863
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
docker-compose.yaml
envoy.yaml
测试请求:
响应:
Ⅴ. Special notes for reviews