-
Notifications
You must be signed in to change notification settings - Fork 9k
YARN-11361 : Remove jQuery dependency #7694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @riya2305 for your work on removing this JQuery.
I saw that some classes or package still name "jquery", e.g. JQueryUI.java
, jquery-ui.css
. Perhaps if we are removing JQuery maybe we should rename all these names to something else instead of JQuery because it seems to me that we are still using JQuery. Please let me know if I misunderstood something about your intentions here.
Also, I saw some check-style failures and missing Apache licenses in some files.
Could you please fix it?
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@@ -159,7 +159,6 @@ function renderHadoopElapsedTime(data, type, full) { | |||
return toReturn; | |||
} | |||
// 'sort', 'type' and undefined all just use the number | |||
return data; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@riya2305 could you help explain why removing this return data
?
Description of PR
jQuery nowadays has little to no benefits, but has a really high maintenance cost (a lot of CVE fixes result in a jQuery upgrade ticket, which then needs thorough manual UI testing). This task is to investigate and replace the jQuery JS code to JavaScript.
How was this patch tested?
tested for YARN UIv1
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?