[MNG-8454] Force the FileSizeFormat UT to US Locale #2003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it uses now String.format that produces different decimal separator based on local, most notable DE --- https://issues.apache.org/jira/browse/MNG-8454
Bukama
reviewed
Dec 20, 2024
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertThrows; | ||
|
|
||
| class FileSizeFormatTest { | ||
| // Locale like DE uses "," and not "." | ||
| // For simplicity’s sake let test in US | ||
| static Locale original; |
There was a problem hiding this comment.
I suggest to use https://junit-pioneer.org/docs/default-locale-timezone/ for this (and yes I'm a maintainer of this project, together with Nicolai Parlog and others)
There was a problem hiding this comment.
Created https://issues.apache.org/jira/browse/MNG-8459 to follow up, right now am interested in fixing this single failure only.
Bukama
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Works with the fix also in German
[INFO] Maven 4 Core ......................................................................................... SUCCESS [ 31.458 s]
[INFO] Maven 4 CLI .......................................................................................... SUCCESS [ 8.805 s]
[INFO] Maven Embedder (deprecated) .......................................................................... SUCCESS [ 6.153 s]
[INFO] Maven Artifact Resolver Provider (deprecated) ........................................................ SUCCESS [ 4.854 s]
[INFO] Maven Compat (deprecated) ............................................................................ SUCCESS [ 14.260 s]
[INFO] Apache Maven Distribution ............................................................................ SUCCESS [ 5.425 s]
[INFO] Maven 4 Executor ..................................................................................... SUCCESS [ 52.184 s]
[INFO] Maven 4 Implementation Modules ....................................................................... SUCCESS [ 0.100 s]
[INFO] Maven Compatibility Modules .......................................................................... SUCCESS [ 0.086 s]
[INFO] --------------------------------------------------------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] --------------------------------------------------------------------------------------------------------------------------
[INFO] Total time: 03:01 min
[INFO] Finished at: 2024-12-20T12:20:47+01:00
[INFO] --------------------------------------------------------------------------------------------------------------------------
According to my comment, just take a look and think about it. I know you want to get the release done (and it's a new dependency).
|
Created follup https://issues.apache.org/jira/browse/MNG-8459 and will merge this PR and close this RC3 issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it uses now String.format that produces different decimal separator based on local, most notable DE. This causes the UT to fail, and hence renders Maven non-buildable on DE systems.
https://issues.apache.org/jira/browse/MNG-8454