-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[SPARK-51927][SPARK-52213][BUILD] Upgrade jackson to 2.19.0 and upgrade kubernetes-client to version 7.3.0 #50730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for testing.
It appears there might be compatibility issues with the Kubernetes client. I need to further verify this. |
It seems that an upgrade to version 2.19.0 is temporarily not feasible at the moment: |
test Jackson 2.19.0 with kubernetes-client 7.3.0 https://github.com/fabric8io/kubernetes-client/releases/tag/v7.3.0 |
cc @dongjoon-hyun I'm not sure if waiting for a while will lead to a better solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @LuciferYang .
Merged to master for Apache Spark 4.1.0. |
Hmmm .. this actually breaks SBT build with PySpark tests for some resasons:
Let me revert it out for now 🙏 |
Oh, thank you for reporting, @HyukjinKwon . |
Thank you @HyukjinKwon |
The root cause is that during the packaging process of the I'll first go and fix the packaging issue with spark-protobuf to ensure consistency in the packaging results between sbt and Maven. Additionally, if we run the following command for testing with maven, it will pass even when using Jackson 2.19.0:
|
@HyukjinKwon I rebased this pr and manually checked the cases you provided after . The previous errors no longer exist. Are there any other scenarios that require manual verification?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's merge it back and see how it goes. What was the cause btw?
I provided an answer to this question here: #50730 (comment)
Then, I fixed the issue yesterday at #50951. |
Thank you, @LuciferYang and @HyukjinKwon ! |
Already merged into master. Thanks @HyukjinKwon and @dongjoon-hyun ~ |
What changes were proposed in this pull request?
The primary objective of this pr is to upgrade Jackson from 2.18.2 to 2.19.0, and simultaneously upgrade the kubernetes-client from 7.2.0 to 7.3.0 to ensure compatibility with Jackson 2.19.0.
Why are the changes needed?
The new version of Jackson brings several bug fixes:
DeserializationContext.readTreeAsValue()
handles null nodes differently fromObjectMapper.treeToValue()
FasterXML/jackson-databind#4934FirstCharBasedValidator.forFirstNameRule()
: returnsnull
in non-default case FasterXML/jackson-databind#5052The full release notes as follow:
The release of kubernetes-client 7.3.0 is solely for the purpose of ensuring compatibility with Jackson 2.19.0:
Does this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No