fix: correct intersection logic in shims.FindExecutable function so ordering of multiple versions is preserved
#2063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ordering of multiple versions is preserved * add more tests for `toolversions.Intersect` function * add failing test for `shims.FindExecutable` function * correct intersection logic in `shims.FindExecutable` function Fixes #2038
Stratus3D
force-pushed
the
tb/multiple-version-order-fix
branch
from
c894399 to
b30494c
Compare
This was referenced May 5, 2025
Merged
Stratus3D
added a commit
that referenced
this pull request
May 16, 2025
… ordering of multiple versions is preserved (#2063)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toolversions.Intersectfunctionshims.FindExecutablefunctionshims.FindExecutablefunctionFixes #2038