Replace WMIC with powershell cmd #4034

leidwang · 2024-11-29T03:39:05Z

From Win11-24H2, WMIC is an optional feature for Windows, And it will be fully removed in the future.So replace the related cmd

ID: 3268

leidwang · 2025-01-08T02:20:39Z

Hi @xiagao @heywji Would you please help test this MR with our acceptance test, thanks.

heywji · 2025-01-15T06:41:09Z

Test 271 acceptance with win2022,win11,win1032 and win2016 guests, this patch worked.

leidwang · 2025-01-15T06:43:39Z

Hi @XueqiangWei @nanliu-r @fbq815 Would you please help test this MR, it is mainly for wmic repalcement.Thanks.

xiagao · 2025-01-16T01:46:03Z

Acceptance test looks good.
LGTM.

mcasquer · 2025-01-16T06:42:32Z

balloon_hotplug test cases now passed in Win2025

 (1/7) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_hotplug.q35: STARTED
 (1/7) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_hotplug.q35: PASS (50028.55 s)
 (2/7) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_hotplug.with_reboot.q35: STARTED
 (2/7) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_hotplug.with_reboot.q35: PASS (939.88 s)
 (3/7) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_hotplug.with_system_reset.q35: STARTED
 (3/7) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_hotplug.with_system_reset.q35: PASS (871.67 s)
 (4/7) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_hotplug.with_shutdown_after_unplug.q35: STARTED
 (4/7) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_hotplug.with_shutdown_after_unplug.q35: PASS (497.14 s)
 (5/7) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_hotplug.with_shutdown_after_plug.q35: STARTED
 (5/7) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_hotplug.with_shutdown_after_plug.q35: PASS (473.43 s)
 (6/7) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_hotplug.with_migrate.migrate_after_hotplug.q35: STARTED
 (6/7) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_hotplug.with_migrate.migrate_after_hotplug.q35: PASS (601.20 s)
 (7/7) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_hotplug.with_migrate.migrate_after_unplug.q35: STARTED
 (7/7) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_hotplug.with_migrate.migrate_after_unplug.q35: PASS (694.86 s)
RESULTS    : PASS 7 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

mcasquer

LGTM

leidwang · 2025-01-22T06:01:26Z

Hi @yanan-fu @YongxueHong Would you please help review this MR?Thanks.

mcasquer · 2025-01-24T09:11:17Z

virttest/utils_windows/drive.py

-    return out if out else []
+    c_name, c_value = cond.split("=")
+    cmd = (
+        'powershell -command "Get-CimInstance -ClassName Win32_LogicalDisk | Where-Object {$_.%s -like %s}'


The disk needs to be under single quotes, same you've done in utils_netperf.py and replace the existing ones by double quotes

Suggested change

'powershell -command "Get-CimInstance -ClassName Win32_LogicalDisk | Where-Object {$_.%s -like %s}'

"powershell -command \"Get-CimInstance -ClassName Win32_LogicalDisk | Where-Object {$_.%s -like '%s'}"

Hi @mcasquer Thank you for your suggestion, actually, c_value already has quotes, you can check line37.

mcasquer · 2025-01-24T09:11:40Z

virttest/utils_windows/drive.py

-        return mapping
-    return {}
+    cmd = (
+        'powershell -command "Get-CimInstance -ClassName Win32_Diskdrive | Where-Object {$_.SerialNumber -eq %s}'


Same as above

Suggested change

'powershell -command "Get-CimInstance -ClassName Win32_Diskdrive | Where-Object {$_.SerialNumber -eq %s}'

"powershell -command \"Get-CimInstance -ClassName Win32_Diskdrive | Where-Object {$_.SerialNumber -eq '%s'}"

Okay, let me confirm it and update the code.

mcasquer · 2025-01-24T09:56:49Z

virttest/utils_windows/drive.py

+            results.append(vals[0])
+        else:
+            results.append(dict(zip(keys, vals)))
+    return results if results else []


@leidwang
Another comment here, this implementation seems to no longer return a map, so this will probably break all the calls to this function.

YongxueHong · 2025-02-05T04:28:16Z

virttest/utils_net.py

+    octets = subnet_mask.split(".")
+
+    prefix_length = 0
+    for octet in octets:
+        prefix_length += bin(int(octet)).count("1")
+
+    return prefix_length


Suggested change

octets = subnet_mask.split(".")

prefix_length = 0

for octet in octets:

prefix_length += bin(int(octet)).count("1")

return prefix_length

return sum(bin(int(octet)).count("1") for octet in subnet_mask.split("."))

Hi @PaulYuuu
Would you like to help to review it?
Thanks. CC @nickzhq

Please note that the netmask in set_guest_ip_addr can be CIDR AND dot-decimal notation, only when users give a dot-decimal notation, we have to convert it to a bitmask.

However, the new function is a duplicate of convert_netmask in utils_net module, and set_guest_ip_addr also used it.

avocado-vt/virttest/utils_net.py

Lines 1641 to 1647 in 731ecab

nic_ifname = get_linux_ifname(session, mac)

if session.cmd_status("which ip") != 0:

info_cmd = "ifconfig -a; ethtool -S %s" % nic_ifname

cmd = "ifconfig %s %s netmask %s" % (nic_ifname, ip_addr, netmask)

else:

if "." in netmask:

netmask = convert_netmask(netmask)

BTW, the current convert_netmask can only handle dot-decimal notation, as we already import ipaddress, an enhancement here is to use it to handle all types of netmask.

>>> import ipaddress >>> ip_addr = "192.168.1.1" >>> netmask = "24" # or "255.255.255.0" >>> ipaddr = ipaddress.IPv4Network(f"{ip_addr}/{netmask}", strict=False) >>> ipaddr.netmask IPv4Address('255.255.255.0') >>> ipaddr.prefixlen 24

And then you can use it for linux/windows

Thank you @YongxueHong @PaulYuuu , let me update my code.

YongxueHong · 2025-02-05T04:59:05Z

virttest/utils_net.py

@@ -3941,19 +3968,22 @@ def update_mac_ip_address(vm, timeout=240):


 def get_windows_nic_attribute(
-    session, key, value, target, timeout=240, global_switch="nic"
+    session, key, value, target, timeout=240, global_switch="NetworkAdapter"


Hi @xiagao
Could you help to review if it will affect the test case: https://github.com/autotest/tp-qemu/blob/6f0573097c77bb5d43b1c52574e12f5735714995/qemu/tests/win_virtio_driver_update_by_installer.py#L108-L109
Thanks.

mcasquer · 2025-03-04T06:56:02Z

virttest/utils_misc.py


    :return: volume ID.
    """
-    cmd = "wmic logicaldisk where (%s) get DeviceID" % condition
+    c_name, c_value = condition.split("=")


@leidwang this logic seems to be incorrect. In the balloon_hotplug variants I am hitting the following:

[stdlog] 2025-03-03 15:09:30,148 avocado.test stacktrace L0050 ERROR| File "/usr/local/lib/python3.9/site-packages/avocado_framework_plugin_vt-109.0-py3.9.egg/virttest/utils_misc.py", line 2482, in get_win_disk_vol [stdlog] 2025-03-03 15:09:30,148 avocado.test stacktrace L0050 ERROR| c_name, c_value = condition.split("=") [stdlog] 2025-03-03 15:09:30,148 avocado.test stacktrace L0050 ERROR| ValueError: not enough values to unpack (expected 2, got 1)

Which leads to:
avocado.core.exceptions.TestError: Could not get virtio-win disk vol!

Same for balloon_service and balloon_memhp variants

Could you add the full debug.log to issue3268, thanks.

@leidwang sorry for the late reply, debug.log updated !

mcasquer · 2025-03-04T07:11:46Z

virttest/utils_test/qemu/__init__.py

@@ -488,7 +488,7 @@ def get_guest_total_mem(cls, vm):
        :return: physical memory report by guest OS in MB
        """
        if vm.params.get("os_type") == "windows":
-            cmd = "wmic ComputerSystem get TotalPhysicalMemory"
+            cmd = 'powershell -command "(Get-CimInstance -ClassName Win32_ComputerSystem).TotalPhysicalMemory"'


@leidwang also hit a timeout with the following command, either executing it on the test loop or individually:
ERROR: Timeout expired while waiting for shell command to complete: 'powershell -command "(Get-CimInstance -ClassName Win32_ComputerSystem).TotalPhysicalMemory"' (output: '')

mcasquer · 2025-04-25T06:24:39Z

Hello @leidwang is there any plan to update this patch ? I am still hitting wmic command issues in Win11 recent test runs 😕

leidwang · 2025-04-25T06:42:35Z

Hello @leidwang is there any plan to update this patch ? I am still hitting wmic command issues in Win11 recent test runs 😕

Hi @mcasquer I will update this MR recently, sorry for the delay.Currently, if you hit the issue that wmic not installed, you can try to run unattended_install test case again, it should be helpful.

Just want to explain more about why we will hit this issue. Win11-24H2 and Win2025 remove wmic, and does not provide installer for wmic, so we have to install it from MSFT, which then requires downloading something from the MSFT server,, so the wmic installation sometimes fails.

mcasquer · 2025-04-25T07:12:00Z

Hello @leidwang is there any plan to update this patch ? I am still hitting wmic command issues in Win11 recent test runs 😕

Hi @mcasquer I will update this MR recently, sorry for the delay.Currently, if you hit the issue that wmic not installed, you can try to run unattended_install test case again, it should be helpful.

Just want to explain more about why we will hit this issue. Win11-24H2 and Win2025 remove wmic, and does not provide installer for wmic, so we have to install it from MSFT, which then requires downloading something from the MSFT server,, so the wmic installation sometimes fails.

@leidwang ok, I get the idea, but if I trigger an automated test loop I cannot run the unattended_install twice, which significantly affects automation purpose...

leidwang · 2025-04-25T07:17:16Z

Hello @leidwang is there any plan to update this patch ? I am still hitting wmic command issues in Win11 recent test runs 😕

Hi @mcasquer I will update this MR recently, sorry for the delay.Currently, if you hit the issue that wmic not installed, you can try to run unattended_install test case again, it should be helpful.
Just want to explain more about why we will hit this issue. Win11-24H2 and Win2025 remove wmic, and does not provide installer for wmic, so we have to install it from MSFT, which then requires downloading something from the MSFT server,, so the wmic installation sometimes fails.

@leidwang ok, I get the idea, but if I trigger an automated test loop I cannot run the unattended_install twice, which significantly affects automation purpose...

Yes, we have to replace all wmic related command in our framework and test cases, then this issue can be fully fixed.

From Win11-24H2, WMIC is an optional feature for Windows, And it will be fully removed in the future.So replace the related cmd Signed-off-by: Leidong Wang <[email protected]>

qcheng-redhat · 2025-04-29T03:17:34Z

Tested with vTPM test cases. LGTM

leidwang force-pushed the wmic_replacement branch 2 times, most recently from 97073f0 to 194ab37 Compare November 29, 2024 12:59

leidwang force-pushed the wmic_replacement branch 2 times, most recently from 1c9d9ea to 7c4813a Compare December 24, 2024 03:11

leidwang marked this pull request as ready for review December 31, 2024 01:43

leidwang force-pushed the wmic_replacement branch 6 times, most recently from 9f86791 to d1bcda5 Compare January 8, 2025 01:55

leidwang mentioned this pull request Jan 8, 2025

Replace WMIC with powershell cmdlet autotest/tp-qemu#4242

Draft

mcasquer approved these changes Jan 16, 2025

View reviewed changes

mcasquer reviewed Jan 24, 2025

View reviewed changes

YongxueHong reviewed Feb 5, 2025

View reviewed changes

leidwang force-pushed the wmic_replacement branch 2 times, most recently from fb627bc to e8aaf97 Compare February 26, 2025 01:10

mcasquer reviewed Mar 4, 2025

View reviewed changes

Replace WMIC with powershell cmd

4e02e10

From Win11-24H2, WMIC is an optional feature for Windows, And it will be fully removed in the future.So replace the related cmd Signed-off-by: Leidong Wang <[email protected]>

leidwang force-pushed the wmic_replacement branch from e8aaf97 to 4e02e10 Compare April 27, 2025 07:12

	'powershell -command "Get-CimInstance -ClassName Win32_LogicalDisk \| Where-Object {$_.%s -like %s}'
	"powershell -command \"Get-CimInstance -ClassName Win32_LogicalDisk \| Where-Object {$_.%s -like '%s'}"

	nic_ifname = get_linux_ifname(session, mac)
	if session.cmd_status("which ip") != 0:
	info_cmd = "ifconfig -a; ethtool -S %s" % nic_ifname
	cmd = "ifconfig %s %s netmask %s" % (nic_ifname, ip_addr, netmask)
	else:
	if "." in netmask:
	netmask = convert_netmask(netmask)

Replace WMIC with powershell cmd #4034

Are you sure you want to change the base?

Replace WMIC with powershell cmd #4034

Uh oh!

Conversation

leidwang commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leidwang commented Jan 8, 2025

Uh oh!

heywji commented Jan 15, 2025

Uh oh!

leidwang commented Jan 15, 2025

Uh oh!

xiagao commented Jan 16, 2025

Uh oh!

mcasquer commented Jan 16, 2025

Uh oh!

mcasquer left a comment

Choose a reason for hiding this comment

Uh oh!

leidwang commented Jan 22, 2025

Uh oh!

mcasquer Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcasquer Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcasquer Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcasquer Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcasquer commented Apr 25, 2025

Uh oh!

leidwang commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcasquer commented Apr 25, 2025

Uh oh!

leidwang commented Apr 25, 2025

Uh oh!

qcheng-redhat commented Apr 29, 2025

Uh oh!

Uh oh!

leidwang commented Nov 29, 2024 •

edited

Loading

mcasquer Jan 24, 2025 •

edited

Loading

mcasquer Jan 24, 2025 •

edited

Loading

mcasquer Jan 24, 2025 •

edited

Loading

mcasquer Mar 4, 2025 •

edited

Loading

leidwang commented Apr 25, 2025 •

edited

Loading