env_process: Refactor EGD setup #4090
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the steps setting and cleaning EGD up into a Setuper that is
registered into the setup_manager in env_process.
This is a patch from a larger patch series refactoring the env_process
preprocess and postprocess functions. In each of these patches, a
pre/post process step is identified and replaced with a Setuper subclass
so the following can finally be met:
- Only cleanup steps of successful setup steps are run to avoid
possible environment corruption or hard to read errors.
- Running setup/cleanup steps symmetrically during env pre/post
process.
- Reduce explicit pre/post process function code length.
Signed-off-by: Beñat Gartzia Arruabarrena <[email protected]>
|
@YongxueHong, yet another one. I'd also appreciate it if @ybduan could have a look into this. Thanks a lot :) |
Hi @ybduan |
|
Hi @ybduan, gentle ping here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the steps setting and cleaning EGD up into a Setuper that is registered into the setup_manager in env_process.
This is a patch from a larger patch series refactoring the env_process preprocess and postprocess functions. In each of these patches, a pre/post process step is identified and replaced with a Setuper subclass so the following can finally be met:
- Only cleanup steps of successful setup steps are run to avoid possible environment corruption or hard to read errors.
- Running setup/cleanup steps symmetrically during env pre/post process.
- Reduce explicit pre/post process function code length.
This patch shouldn't introduce any regression or breaking change.
With
--testcase=boot --rng_type=virtio_rng.rng_egd:ID: 2941