feat!: add MappingSource to the refactor API
#559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new type, `MappingSource`, that allows the user to tell how they want the toolkit to get the mappings: computing it, using an explicitly provided one, or using the reverse of an explicitly provided one. This replaces three previous separate properties: `exclude`, `mappings` and `revert` with a single `mappingSource`. This is a breaking change.
otaviomacedo
had a problem deploying
to
integ-approval
GitHub Actions
Failure
Signed-off-by: github-actions <[email protected]>
aws-cdk-automation
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
- Coverage 79.09% 79.00% -0.09%
==========================================
Files 47 47
Lines 7074 7082 +8
Branches 791 790 -1
==========================================
Hits 5595 5595
- Misses 1460 1468 +8
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
mrgrain
reviewed
May 30, 2025
mrgrain
reviewed
May 30, 2025
mrgrain
reviewed
May 30, 2025
mrgrain
reviewed
May 30, 2025
mrgrain
reviewed
May 30, 2025
mrgrain
reviewed
May 30, 2025
otaviomacedo
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new type,
MappingSource, that allows the user to tell how they want the toolkit to get the mappings: computing it, using an explicitly provided one, or using the reverse of an explicitly provided one.BREAKING CHANGE: This replaces three previous separate properties:
exclude,mappingsandrevertwith a singlemappingSource.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license