Skip to content

Ignore unknown properties on endpoints in endpoint rules. #6139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alextwoods
Copy link
Contributor

Warn instead of raising an exception on unknown endpoint properties.

Motivation and Context

The Rules engine Endpoint Object Properties member is defined as an arbitrary Map<string, object> and to support forwards compatibility/extensibility and comply with the specification, we should not be failing when an unknown property is present in the rules.

Modifications

  • Change the exception to a logger warning when an unknown (at this point, anything other than authSchemes) property is encountered in an Endpoint object.

Testing

Added new test case with endpoint rules with unknown property.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods requested a review from a team as a code owner May 28, 2025 21:24
@alextwoods alextwoods requested a review from sugmanue May 28, 2025 21:24
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants