Update generator plugin to support validators #6142
Conversation
dagnir
force-pushed
the
dongie/shared-models-validation-pt2
branch
from
b18ecd1 to
692139c
Compare
This commit updates the generation mojo to suppport validators: - Add flag for controling whether the validation report is written to disk - Build all models to IntermediateModel upfront - If a service model targets another for sharing shapes, also pass in the target service IntermedidateModel
dagnir
force-pushed
the
dongie/shared-models-validation-pt2
branch
from
692139c to
b910ad2
Compare
|
| IntermediateModel previous = serviceNameToModelMap.put(lowercaseServiceName, model); | ||
| if (previous != null) { | ||
| String warning = String.format("Multiple service models found with service name %s. Model validation " | ||
| + "will likely be incorrect", lowercaseServiceName); |
There was a problem hiding this comment.
Why is will likely be incorrect do we have any valid cases where multiple models have same service name , why just warn and not error ?
There was a problem hiding this comment.
I can't think of a valid case honestly. I only encountered this in testing when the generator runs for the codegen-generated-classes-test since we have a lot of test models there and some have the same name, and all in the same package, so erroring out in that case is not productive.
The worst case scenario is compilation will just fail in that case so this should be fine. We could consider adding a "skipValidation" flag in the future.
dagnir
merged commit f981caa
into
feature/master/codegen-validation
Motivation and Context
This commit updates the generation mojo to suppport validators:
Modifications
Testing
Testing report output
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License