Skip to content

#1070 Set process.env.NODE_BACKEND to 'js' within the bcoin-browser.js file. #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2022
Merged

#1070 Set process.env.NODE_BACKEND to 'js' within the bcoin-browser.js file. #1071

merged 1 commit into from
Jul 14, 2022

Conversation

Randy808
Copy link
Contributor

@Randy808 Randy808 commented Jul 2, 2022

This addresses issue #1070

@Randy808 Randy808 changed the title Set process.env.NODE_BACKEND to 'js' within the bcoin-browser.js file. #1070 Set process.env.NODE_BACKEND to 'js' within the bcoin-browser.js file. Jul 2, 2022
@pinheadmz
Copy link
Member

Confirmed this change solves the issue, but I agree with the lint error, style should be:

diff --git a/lib/bcoin-browser.js b/lib/bcoin-browser.js
index deaaec06e..1f7254be8 100644
--- a/lib/bcoin-browser.js
+++ b/lib/bcoin-browser.js
@@ -5,10 +5,10 @@
  * https://github.com/bcoin-org/bcoin
  */
 
-process.env.NODE_BACKEND = "js";
-
 'use strict';
 
+process.env.NODE_BACKEND = 'js';
+
 /**
  * A bcoin "environment" which exposes all
  * constructors for primitives, the blockchain,

@Randy808
Copy link
Contributor Author

Randy808 commented Jul 7, 2022

@pinheadmz Got it. I just amended the commit to use single quotes

@pinheadmz
Copy link
Member

pinheadmz commented Jul 8, 2022

I think you also need to ensure that 'use strict' is on top, to pass the linter

/home/circleci/repo/lib/bcoin-browser.js
  8:1  error  Use the global form of 'use strict'  strict

@codecov-commenter
Copy link

Codecov Report

Merging #1071 (1b72372) into master (d83abd8) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1071      +/-   ##
==========================================
- Coverage   66.93%   66.90%   -0.03%     
==========================================
  Files         157      157              
  Lines       26060    26061       +1     
==========================================
- Hits        17443    17437       -6     
- Misses       8617     8624       +7     
Impacted Files Coverage Δ
lib/bcoin-browser.js 0.00% <0.00%> (ø)
lib/golomb/reader.js 77.35% <0.00%> (-11.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83abd8...1b72372. Read the comment docs.

@Randy808
Copy link
Contributor Author

Amended the commit to have 'use strict' at the top of the file to pass linter validation

@pinheadmz pinheadmz merged commit fe45c30 into bcoin-org:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants