Skip to content

integration tests should validate packet count #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Billy99 opened this issue Feb 26, 2025 · 0 comments
Open

integration tests should validate packet count #385

Billy99 opened this issue Feb 26, 2025 · 0 comments
Labels
good first issue Good for newcomers
Milestone
Q1-2025

Comments

@Billy99
Copy link
Contributor

Billy99 commented Feb 26, 2025

Some of the integration tests (doTcCheck(), doTcxCheck(), doXdpCheck()) aren't testing for a non-zero count. They are just checking for the string "packets received" and "bytes received", whereas their App equivalent (doAppTcCheck(), doAppTcxCheck(), doAppXdpCheck()) make sure a non-zero count is received. Make these tests more like their App equivalent.
@github-project-automation github-project-automation bot moved this to 🆕 New in bpfman Feb 26, 2025
@Billy99 Billy99 added this to the Q1-2025 milestone Mar 6, 2025
@Billy99 Billy99 added the good first issue Good for newcomers label Mar 6, 2025
msherif1234 pushed a commit to msherif1234/bpfman-operator that referenced this issue Apr 1, 2025
@openshift-merge-bot
Merge pull request bpfman#385 from openshift/konflux/component-update…
c28c3a4 
…s/component-update-ocp-bpfman-operator-bundle

chore(deps): update ocp-bpfman-operator-bundle to f8757c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
bpfman
Status: 🆕 New
Milestone
Q1-2025
Development

No branches or pull requests
1 participant
@Billy99