Skip to content

Makefile: Split build image tasks for better modularity #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

frobware
Copy link
Contributor

@frobware frobware commented Sep 6, 2024

Refactored the build-images target to explicitly split the build process into two separate tasks: build-bpfman-operator-image and build-bpfman-agent-image. This change is aimed at improving day-to-day development workflow.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.61%. Comparing base (7bac877) to head (bc57546).
Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   27.61%   27.61%           
=======================================
  Files          81       81           
  Lines        6999     6999           
=======================================
  Hits         1933     1933           
  Misses       4877     4877           
  Partials      189      189           
Flag Coverage Δ
unittests 27.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Refactored the build-images target to explicitly split the build process
into two separate tasks: build-bpfman-operator-image and
build-bpfman-agent-image. This change is aimed at improving day-to-day
development workflow.

Signed-off-by: Andrew McDermott <[email protected]>
@frobware frobware force-pushed the split-build-images-into-constituent-parts branch from ba4ba25 to bc57546 Compare September 9, 2024 14:17
Copy link
Contributor

@Billy99 Billy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify mergify bot merged commit faf387f into bpfman:main Sep 9, 2024
20 checks passed
msherif1234 pushed a commit to msherif1234/bpfman-operator that referenced this pull request Dec 17, 2024
…s/ocp-bpfman-operator-bundle

chore(deps): update ocp-bpfman-operator-bundle to 8650a0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants