Makefile: gracefully handle kubectl delete #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify `undeploy` and `catalog-undeploy` targets in the Makefile to include the `--ignore-not-found` flag when deleting resources. This ensures that resource deletion commands do not error out when resources are already absent. This follows the existing pattern for handling non-existent resources in `kubectl delete` calls throughout the Makefile. Signed-off-by: Andrew McDermott <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 27.39% 27.39%
=======================================
Files 81 81
Lines 6968 6968
=======================================
Hits 1909 1909
Misses 4873 4873
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/LGTM |
msherif1234
pushed a commit
to msherif1234/bpfman-operator
that referenced
this pull request
Nov 6, 2024
Merge 10 30 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
undeployandcatalog-undeploytargets in the Makefile toinclude the
--ignore-not-foundflag when deleting resources. Thisensures that resource deletion commands do not error out when resources
are already absent. This follows the existing pattern for handling
non-existent resources in
kubectl deletecalls throughout theMakefile.