Skip to content

[tests/simple_streams] add test case for no image-downloads #4119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xmkg
Copy link
Member

@xmkg xmkg commented May 28, 2025

It is causing spurious coverage-related CI failures, such as: https://app.codecov.io/gh/canonical/multipass/pull/4090/indirect-changes

MULTI-2005

@xmkg xmkg force-pushed the bugfix/add-missing-simplestreams-test-case branch from bd6c8b8 to e5669eb Compare May 28, 2025 08:30
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmkg xmkg enabled auto-merge May 28, 2025 10:54
@xmkg xmkg added this pull request to the merge queue May 28, 2025
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.31%. Comparing base (3d329cb) to head (e5669eb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4119   +/-   ##
=======================================
  Coverage   89.31%   89.31%           
=======================================
  Files         259      259           
  Lines       15715    15715           
=======================================
  Hits        14036    14036           
  Misses       1679     1679           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 28, 2025
@xmkg xmkg added this pull request to the merge queue May 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 28, 2025
@xmkg xmkg added this pull request to the merge queue May 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2025
@sharder996 sharder996 added this pull request to the merge queue May 29, 2025
github-merge-queue bot pushed a commit that referenced this pull request May 29, 2025
…ams-test-case

[tests/simple_streams] add test case for no image-downloads
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2025
@xmkg xmkg added this pull request to the merge queue May 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2025
@xmkg xmkg added this pull request to the merge queue May 29, 2025
github-merge-queue bot pushed a commit that referenced this pull request May 29, 2025
…ams-test-case

[tests/simple_streams] add test case for no image-downloads
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2025
@xmkg xmkg added this pull request to the merge queue May 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants