Alphabetize typed_insts.h #5401
Conversation
As requested [here](carbon-language#5400 (comment))
|
I'm not sure this is a net improvement, to be honest. In particular, in some cases the concrete inst kinds rely on an |
| // Common representation for various `*binding_pattern` nodes. | ||
| struct AnyBindingPattern { |
There was a problem hiding this comment.
Hm, I hadn't thought about also alphabetizing the categories (previously they'd been immediately before their first member), but I think this is probably appropriate. In addition, I'd be inclined to move them out to a separate file. I don't remember if we already have something in place to check that a category is compatible with all of its members, but maybe now is the time to add such a check if we don't have it already.
|
FWIW, I'm fine with this (slight preference for lexicographic sorting because it's easier to find things, agreeing it's not a big win in this case). But I'm happy to let zygoloid review. And I pretty much agree that splitting files might be helpful towards a better end result. |
As requested here.