Skip to content

Update class tests for ranges, preludes, and splits #5531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented May 23, 2025

I'm hoping this is the biggest PR I make for a directory. It's doing a number of different things:

  • Dropping a lot of i32 use to be able to switch to no_prelude and min_prelude
  • Combining tests in files (126 files -> 70 files)
    • I think todo_access_modifiers.carbon was done (see access_modifiers.carbon), so just removing that
  • Adding ranges
    • Some files I've not added ranges, thinking the type checking is good enough.

Sorry about the size of this PR, but I'm unsure what's best for review.

@jonmeow
Copy link
Contributor Author

jonmeow commented May 23, 2025

Note I split out the formatter.cpp/h changes to #5530 to avoid them being a topic here. But I need the base because it's a crash bug.

@jonmeow jonmeow force-pushed the class-tests branch 2 times, most recently from 47967cc to 92105b4 Compare May 23, 2025 23:21
Copy link
Contributor

@geoffromer geoffromer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some tests are failing?

@jonmeow
Copy link
Contributor Author

jonmeow commented May 27, 2025

Looks like some tests are failing?

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants