Move struct param tests to a dedicated file #5539
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `struct_definition_return_type.h` and not `struct_decl_return_type.h`
…on for moving tests
…move them from `function.carbon`
danakj
reviewed
May 27, 2025
|
|
||
| auto foo(S) -> void; | ||
|
|
||
| // --- fail_todo_import_struct_decl_param_type.carbon |
There was a problem hiding this comment.
S is going to need to be complete for a call to foo() to happen, if S is passed by value, so this is never going to pass as written, right?
https://godbolt.org/z/x3e5ao9Y9
auto foo(S*) -> void could pass though. Do you want to write it that way?
|
|
||
| struct F; | ||
|
|
||
| F foo(); | ||
|
|
||
| // --- fail_todo_import_struct_return_type.carbon | ||
| // --- fail_todo_import_struct_decl_return_type.carbon |
There was a problem hiding this comment.
Similar to above, calling foo() will not ever pass if F is not complete: https://godbolt.org/z/hn5WroTTP
Do you want to change it to auto foo() -> F* or..?
| // ============================================================================ | ||
|
|
||
| // --- struct_return_type.h | ||
| // --- struct_decl_return_type.h | ||
|
|
||
| struct F; |
There was a problem hiding this comment.
Maybe this can be struct S to not confuse things with fn F in the next file split
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done in stages for easier review, see commits.
Based on #5537.
Part of #5533.