sql/parser: remove no longer used keywords #147386
Merged
+107
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
yuzefovich
force-pushed
the
parser-unused-keywords
branch
from
e7100fc to
d576148
Compare
For some reason, Go library bazel target for the PLpgSQL parser package was named `plpgparser`. This creates a problem with an attempt to add a test that lives in `parser` (as opposed to `parser_test`), so rename the target to `parser` which follows the convention elsewhere. (I eventually decided against adding a test but thought it'd be nice to clean things up.) Release note: None
This commit removes a handful of unreserved keywords that are no longer used. Additionally, it refactors existing `reserved_keywords.awk` into a shell script that is run via a unit test to assert that no longer used keywords get removed promptly. (I tried applying the same script to PLpgSQL and JSONPath parsers, and it found nothing for the latter and produced many false positives for the former, so I decided to not include the corresponding test.) Release note: None
yuzefovich
force-pushed
the
parser-unused-keywords
branch
from
d576148 to
f50a1b4
Compare
yuzefovich
changed the title
yuzefovich
requested review from
mw5h and
DrewKimball
and removed request for
a team and
mw5h
DrewKimball
approved these changes
May 29, 2025
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
|
TFTR! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plpgsql/parser: rename bazel target name for the package
For some reason, Go library bazel target for the PLpgSQL parser package
was named
plpgparser. This creates a problem with an attempt to adda test that lives in
parser(as opposed toparser_test), so renamethe target to
parserwhich follows the convention elsewhere. (Ieventually decided against adding a test but thought it'd be nice to
clean things up.)
sql/parser: remove no longer used keywords
This commit removes a handful of unreserved keywords that are no longer
used. Additionally, it refactors existing
reserved_keywords.awkintoa shell script that is run via a unit test to assert that no longer used
keywords get removed promptly. (I tried applying the same script to
PLpgSQL and JSONPath parsers, and it found nothing for the latter and
produced many false positives for the former, so I decided to not
include the corresponding test.)
Epic: None
Release note: None