Skip to content

Bump Maximum version of SNP Attestation Report. #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DGonzalezVillal
Copy link
Contributor

Version 4 of the attestation report has arrived into some people's machines, so we have to bump up the minimum version to allow them to continue to attest their coco environment.

Slack issue:
https://cloud-native.slack.com/archives/C039JSH0807/p1740776076921049

Version 4 of the attestation report has arrived into some people's machines, so we have to bump up the minimum version to allow them to continue to attest their coco environment.

Signed-off-by: DGonzalezVillal <[email protected]>
@DGonzalezVillal DGonzalezVillal requested a review from a team as a code owner March 6, 2025 23:09
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we haven't updated to the latest virtee/sev code, what will happen if we actually get a v4 (or v3) report? Will it deserialize it with some fields missing or will it explode?

@DGonzalezVillal
Copy link
Contributor Author

Since we haven't updated to the latest virtee/sev code, what will happen if we actually get a v4 (or v3) report? Will it deserialize it with some fields missing or will it explode?

So without the Virtee changes with the V3 of the report, only some fields won't be present but attestation and verification should still work. This has been confirmed internally so V3 reports should not be an issue.

V4 of the report might be a different story although, and we might need to do some internal testing. V4 is introducing a change to TCB. The structure of the TCB will be different in V4 reports depending on your Processor model!

So Genoa and Milan will retain the known TCB format, but Turin (and new gen Procs) will have the new TCB format. This may affect verification if you are doing any type of TCB verification, since the new TCB will have entries moved around to different places. You can find more info in the SNP ABI.

The good news is that we just merged a big change to the SEV library (virtee/sev#278) and after we are done with some testing, we will release a library crate that contains support for both V3 and V4 versions of the report.

I will then put a PR to do the proc generation certificate (add support for Genoa and Turin) and will make sure that the changes work fine with v3 and v4 of the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants