crun: chown std streams #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flouthoc
reviewed
Oct 13, 2021
| if (UNLIKELY (ret < 0)) | ||
| return crun_make_error (err, errno, "fchown std stream %i", i); | ||
| } | ||
| } |
There was a problem hiding this comment.
I think return 0; needs to be added here for success case.
|
This pull request introduces 1 alert when merging 57d982e into 9e2ed72 - view on LGTM.com new alerts:
|
giuseppe
force-pushed
the
chown-std-streams
branch
from
57d982e to
4d0a4c9
Compare
|
LGTM |
|
Do we need additional capabilities by caller before calling |
chown the std streams file descriptors, when they are not a tty, to the user in the container. Closes: containers#745 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
chown-std-streams
branch
from
4d0a4c9 to
cab3d52
Compare
pushed a new version. I think we need to ignore EINVAL and EPERM, as runc does |
flouthoc
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chown the std streams file descriptors, when they are not a tty, to
the user in the container.
Closes: #745
Signed-off-by: Giuseppe Scrivano [email protected]