Skip to content

Fix TestSafeLink on ARM64 #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Jun 25, 2024

This PR fixes the TestSafeLink test which fails on ARM64.

The failing test:

--- FAIL: TestSafeLink (0.00s)
    filesystem_linux_test.go:176: 
        	Error Trace:	/root/projects/containers/storage/pkg/chunked/filesystem_linux_test.go:176
        	Error:      	Not equal: 
        	            	expected: uint32(0x2)
        	            	actual  : uint64(0x2)
        	Test:       	TestSafeLink 

This is because the Stat_t structure has different data types, see arm version. The same problem is solved in the function getNlink().

@rhatdan
Copy link
Member

rhatdan commented Jun 25, 2024

/approve
/lgtm
Thanks @Honny1

Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3ac3f4a into containers:main Jun 25, 2024
18 checks passed
@Honny1 Honny1 deleted the fix-arm64 branch July 1, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants