[1.57] Fall back …, bump limit to 150 MB, and tag as 1.57.1 #2241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to split fields by purpose, and document some of the context. For consistency, use the same order in the struct literals. Only reorders existing fields, should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Instead, have the callees produce ErrFallbackToOrdinaryLayerDownload directly. Signed-off-by: Miloslav Trmač <[email protected]>
That's a logically better place, it pairs the getBlobAt calls with the ErrBadRequest types specific to those call sites. We will, also, add more fallback reasons. Signed-off-by: Miloslav Trmač <[email protected]>
... but not if the fallback would be convert_images, again creating too large metadata. Signed-off-by: Miloslav Trmač <[email protected]>
We have seen an image with: - total size 1.43 GB - uncompressed zstd:chunked manifest size of 91.7 MB - uncompressed tar-split size (not constrained by maxTocSize) 310 MB Without more infrastructure, we are just guessing about what the system we are running on can support, so, for now, *shrug*, bump the number. Eventually we should stream the data from/to disk, making this much less relevant; that makes building the infrastructure to estimate available memory unattractive. Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
|
@mtrmac I'd rather merge this one, but somehow the version file was a -dev. I think I've corrected that now, fingers crossed. |
mtrmac
force-pushed
the
chunked-too-large-with-bump-1.57
branch
from
e3c4a4a to
d16a375
Compare
|
@TomSweeneyRedHat My mistake, I forgot to switch the PR destination. Hopefully fixed now. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@TomSweeneyRedHat Tests are green. |
|
/lgtm |
openshift-merge-bot
bot
merged commit f4d2e9c
into
containers:release-1.57
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #2239 + a cherry-pick of #2240, just so that we have choices.