Skip to content

Add Firecrawl template #5787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: next
Choose a base branch
from
Open

Add Firecrawl template #5787

wants to merge 12 commits into from

Conversation

yipfram
Copy link

@yipfram yipfram commented May 8, 2025

Changes

Added firecrawl service template:

  • Created firecrawl.yaml

  • Added logo

  • Also had to push an image of Playwright service to avoid local build see (original docker-compose.yaml (the playwright image is built locally which require to pull the repo, not possible with coolify template).

Issues

=> This is my first ever pull request in a public repo, don't hesitate to tell me how to improve it :)

@yipfram yipfram marked this pull request as draft May 8, 2025 07:25
@yipfram yipfram marked this pull request as ready for review May 8, 2025 07:25
@andrasbacsai andrasbacsai deleted the branch coollabsio:next May 9, 2025 06:31
@andrasbacsai
Copy link
Member

It was a mistake, sorry. I recreated the next branch and it auto-closed this PR.

@andrasbacsai andrasbacsai reopened this May 9, 2025
@peaklabs-dev
Copy link
Member

We cannot allow personal images for services. So if there is no official image for playwrite, we cannot add it to the official templates. Can you please check if you can find an official image?

@peaklabs-dev peaklabs-dev added the 💤 Waiting for feedback Issues awaiting a response from the author. label May 13, 2025
@yipfram
Copy link
Author

yipfram commented May 14, 2025

Hi, sure I understand. However i have a question: Can we use a standard image for playwrite (like here) or should we only use an official image from firecrawl in which case we will have to wait..

The issue was discussed here but no reply for an official image...

@peaklabs-dev
Copy link
Member

Yes, the standard image should be fine as it is an "official playwrite image", just not the Firecrawl one, so not sure if it will work but if it does that is fine.

@peaklabs-dev peaklabs-dev added 💤 Waiting for changes PRs awaiting changes from the author. and removed 💤 Waiting for feedback Issues awaiting a response from the author. labels May 14, 2025
@yipfram
Copy link
Author

yipfram commented May 14, 2025

Just tested the docker image "mcr.microsoft.com/playwright:v1.52.0-noble"
It works !

I also changed the yaml to add SERVICE_FQDN (I mixed up my version of the code in local... Pushed the wrong one in PR).
I will change it now.

@yipfram
Copy link
Author

yipfram commented May 14, 2025

Don't hesitate to give me some feedback about how to make a PR, I am pretty sure that I can improve a lot of things :)

Happy to contribute to my first project :)

@yipfram yipfram closed this May 15, 2025
@github-actions github-actions bot removed the 💤 Waiting for changes PRs awaiting changes from the author. label May 15, 2025
@yipfram
Copy link
Author

yipfram commented May 15, 2025

oups little error... how can I fix this @peaklabs-dev ? Should I do a new PR?

@yipfram yipfram reopened this May 15, 2025
@yipfram
Copy link
Author

yipfram commented May 22, 2025

Turns out the new image has issues ...

@peaklabs-dev peaklabs-dev added ⚙️ Service Issues requesting or PRs adding/fixing service templates. 💤 Waiting for changes PRs awaiting changes from the author. labels May 23, 2025
@coollabsio coollabsio deleted a comment from gitguardian bot May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Service Issues requesting or PRs adding/fixing service templates. 💤 Waiting for changes PRs awaiting changes from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants