-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add Firecrawl template #5787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Add Firecrawl template #5787
Conversation
It was a mistake, sorry. I recreated the |
We cannot allow personal images for services. So if there is no official image for playwrite, we cannot add it to the official templates. Can you please check if you can find an official image? |
Yes, the standard image should be fine as it is an "official playwrite image", just not the Firecrawl one, so not sure if it will work but if it does that is fine. |
Just tested the docker image "mcr.microsoft.com/playwright:v1.52.0-noble" I also changed the yaml to add SERVICE_FQDN (I mixed up my version of the code in local... Pushed the wrong one in PR). |
Don't hesitate to give me some feedback about how to make a PR, I am pretty sure that I can improve a lot of things :) Happy to contribute to my first project :) |
oups little error... how can I fix this @peaklabs-dev ? Should I do a new PR? |
Turns out the new image has issues ... |
Changes
Added firecrawl service template:
Created firecrawl.yaml
Added logo
Also had to push an image of Playwright service to avoid local build see (original docker-compose.yaml (the playwright image is built locally which require to pull the repo, not possible with coolify template).
Issues
=> This is my first ever pull request in a public repo, don't hesitate to tell me how to improve it :)