-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix keyboard input in mobile browsers #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks, this looks like a good approach! We could use some help with testing. I've deployed this version here: https://copy.sh/v86-staging/ Testing on ios: Both versions open the OS keyboard and work fine. The only differences seems to be that the new version scrolls to the top of the screen. This probably needs an It would be nice if we could find a way to "downgrade" to using the keydown:
if(e.code === "Unspecified")
{
// let the input handler run
return;
}
// call preventDefault here to prevent the input handler
// or, if that is not robust, disable the input handler until the next keyup event |
Same on Android, it because Lines 2590 to 2592 in a3840e3
EDIT: I sketched out a few ideas on how to fix it:
|
I pushed a fix to prevent screen scrolling and tried to fix keyboard and mouse in graphical OSes (on copy.sh/v86 it always opens the keyboard). |
Fixes #262 (and probably #1212) by adding
input
event handler, tested in Chrome and Firefox on Android.