tests/platforms: add test for Azure NVMe udev rules #3519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmijo
force-pushed
the
add-azure-nvme-test
branch
from
15013d3 to
ab01190
Compare
marmijo
added a commit
to marmijo/fedora-coreos-pipeline
that referenced
this pull request
May 22, 2025
Expand the job to build Hyper-V Gen2 gallery images and run kola tests on both traditional managed images and new Gen2 gallery images[1]. The new NVMe test[2] is explicitly denylisted from managed image testing since since it requires Gen2 support. This will essentially allow all Azure kola tests to be validated on both kinds of images. A pipeline config variable, `test_gallery`, is introduced to the Azure section to specify the gallery used to create Gen2 images. [1]: coreos/coreos-assembler#4109 [2]: coreos/fedora-coreos-config#3519
marmijo
force-pushed
the
add-azure-nvme-test
branch
from
ab01190 to
91c7f87
Compare
dustymabe
reviewed
May 27, 2025
|
|
||
| # check symlinks for the os disk | ||
| azure_os_symlink="/dev/disk/azure/os" | ||
| if [ ! -e "$azure_os_symlink" ]; then |
There was a problem hiding this comment.
Any chance of these checks running early enough and racing with the thing that creates the symlinks (i.e. udev)?
There was a problem hiding this comment.
There's definitely a chance of a race. I'll update the test to wait for the symlink to exist before proceeding with the checks.
dustymabe
reviewed
May 27, 2025
|
|
||
| # check symlinks for the data disk | ||
| azure_data_symlink="/dev/disk/azure/data/by-lun/0" | ||
| if [ ! -e "$azure_data_symlink" ]; then |
There was a problem hiding this comment.
Instead of -e (existence) should we be checking to make sure it is actually a symlink (-h or -L)?
There was a problem hiding this comment.
Good point! I think it makes sense to explicitly check that the path is a symlink (not just that it exists), and also verify that it points to a valid path. I realize I have those two mixed up here. I'll update the test to do both so we have full confidence the udev rules are working as expected.
marmijo
force-pushed
the
add-azure-nvme-test
branch
from
91c7f87 to
543ff1d
Compare
dustymabe
approved these changes
May 27, 2025
marmijo
added a commit
to marmijo/fedora-coreos-pipeline
that referenced
this pull request
May 29, 2025
Modify the job to build Hyper-V Gen2 gallery images and run kola tests exclusively on those new images[1]. The new Azure NVMe test[2] requires NVMe support, which is only available with Gen2 gallery images. Since there are no constraints requiring Gen1 images, we simplify things by testing only Gen2. A pipeline config variable, `test_gallery`, is introduced to the Azure section to specify the gallery used to create Gen2 images. [1]: coreos/coreos-assembler#4109 [2]: coreos/fedora-coreos-config#3519
marmijo
added a commit
to marmijo/fedora-coreos-pipeline
that referenced
this pull request
May 29, 2025
Modify the job to build Hyper-V Gen2 gallery images and run kola tests exclusively on those new images[1]. The new Azure NVMe test[2] requires NVMe support, which is only available with Gen2 gallery images. Since there are no constraints requiring Gen1 images, we simplify things by testing only Gen2. A pipeline config variable, `test_gallery`, is introduced to the Azure section to specify the gallery used to create Gen2 images. [1]: coreos/coreos-assembler#4109 [2]: coreos/fedora-coreos-config#3519
marmijo
added a commit
to coreos/fedora-coreos-pipeline
that referenced
this pull request
May 29, 2025
Modify the job to build Hyper-V Gen2 gallery images and run kola tests exclusively on those new images[1]. The new Azure NVMe test[2] requires NVMe support, which is only available with Gen2 gallery images. Since there are no constraints requiring Gen1 images, we simplify things by testing only Gen2. A pipeline config variable, `test_gallery`, is introduced to the Azure section to specify the gallery used to create Gen2 images. [1]: coreos/coreos-assembler#4109 [2]: coreos/fedora-coreos-config#3519
Introduce a new test which verifies that udev rules[1] for Azure Managed NVMe disks correctly create symlinks in `/dev/disk/azure`. It only runs on Azure and uses new kola functionality[2] to override the instance type, enabling the use of a Hyper-V Gen2 VM (Standard_M16bds_v3) with a UltraSSD_LRS (NVMe) data disk attached. The test checks for the presence of OS and data disk symlinks, and that they point to a valid target. [1]: coreos#3378 [2]: coreos/coreos-assembler#4109
marmijo
force-pushed
the
add-azure-nvme-test
branch
from
543ff1d to
ac798ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new test which verifies that udev rules
[1]for Azure Managed NVMe disks correctly create symlinks in/dev/disk/azure. It only runs on Azure and uses new kola functionality[2]to override the instance type, enabling the use of a Hyper-V Gen2 VM (Standard_M16bds_v3) with a UltraSSD_LRS (NVMe) data disk attached.The test checks for the presence of expected symlinks:
[1]: #3378[2]: coreos/coreos-assembler#4109Note: This test requires coreos/coreos-assembler#4109 to merge first, and also requires changes to the fedora-coreos-pipeline
kola-azurejob to handle building and resting this on gen2 images.