Skip to content

Remove openmp support for imagemagick #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 31, 2025
Merged

Remove openmp support for imagemagick #681

merged 12 commits into from
Mar 31, 2025

Conversation

crazywhalecc
Copy link
Owner

What does this PR do?

Fix #678

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php, run composer cs-fix at local machine.
  • If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, update docs in ./docs/.
  • If you updated config/xxx.json content, run bin/spc dev:sort-config xxx.

@crazywhalecc crazywhalecc added bug Something isn't working kind/dependency Issues related to dependencies os/linux Things only for Linux OS labels Mar 29, 2025
@crazywhalecc crazywhalecc marked this pull request as ready for review March 29, 2025 14:52
@crazywhalecc
Copy link
Owner Author

Looks good to me and main branch of frankenphp.

@crazywhalecc crazywhalecc requested a review from henderkes March 29, 2025 15:23
@henderkes
Copy link
Collaborator

does this patch work for imagick.so as well? I think if we choose to match something rather than pass the ac_has_omp_pause_resource_all=op to php build, we should directly patch the ext-imagick/config.m4 from where it originates

@crazywhalecc
Copy link
Owner Author

crazywhalecc commented Mar 30, 2025

I tried but it still dont generate HAVE_OMP_PAUSE_RESOURCE_ALL 0. The safest way (maybe?) is to define it manually. But for imagick.so I haven't tried yet. It seems depends on embed's php_config.h.

@henderkes
Copy link
Collaborator

Okay I'll test and merge it later today, thank you

@henderkes
Copy link
Collaborator

henderkes commented Mar 30, 2025

@crazywhalecc this is good to be merged from my side, but you might want to amend the Chinese docs.

@crazywhalecc crazywhalecc merged commit 6108433 into main Mar 31, 2025
10 checks passed
@crazywhalecc crazywhalecc deleted the fix/remove-libgomp branch March 31, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kind/dependency Issues related to dependencies os/linux Things only for Linux OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libgomp dependency in imagick
2 participants