Skip to content

explicitly state libheif -> --with-heic #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Conversation

henderkes
Copy link
Collaborator

What does this PR do?

explicitly states --with-heic when using libheif (still default)

Maybe we should make libheic optional though, to see how it plays out with:
dunglas/frankenphp#1487

@henderkes henderkes force-pushed the fix/libheif-with-heic branch from 712a429 to 4391c30 Compare April 12, 2025 03:06
@crazywhalecc crazywhalecc added bug Something isn't working kind/dependency Issues related to dependencies labels Apr 12, 2025
@crazywhalecc
Copy link
Owner

Is the current problem that heif cannot be used in imagick? I am not sure the purpose of doing this.

If it is to be an optional dependency, then gd should also set it as an optional dependency.

@henderkes
Copy link
Collaborator Author

No, the problem is that we are relying on imagemagick behaving against spec qnd automatically including heic support even if it wasn't configured to. We shouldbe explicit about heic support by passing --with-heic

@crazywhalecc
Copy link
Owner

Makes sense. But we should also modify lib.json.

@henderkes
Copy link
Collaborator Author

I haven't made it optional yet, that could be another PR if we really want. Most people using imagick would probably want heif support so it's ok to keep it a dependency.

I believe the core issue about the frankenphp crash was the -march-native optimisation that we added to the static-builder dockerfiles, not the libde265 itself.

@henderkes henderkes merged commit 5e67133 into main Apr 14, 2025
20 checks passed
@crazywhalecc crazywhalecc deleted the fix/libheif-with-heic branch April 15, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kind/dependency Issues related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants