Skip to content

Added setup files for pypi submission #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2016
Merged

Conversation

lhl
Copy link
Contributor

@lhl lhl commented Jul 26, 2016

Hey Daniel, saw this wrapper and was going to give it a try, but it'd be more useful if it was in pypi?
I've added the setup files to give that a bit of a push.

For a simple guide on adding packages to pypi (it's not too bad):
http://peterdowns.com/posts/first-time-with-pypi.html
https://packaging.python.org/distributing/
https://hynek.me/articles/sharing-your-labor-of-love-pypi-quick-and-dirty/

@danpaquin
Copy link
Owner

Awesome! I will work on this and hopefully submit the app to pypi this week if all goes well.

@lhl
Copy link
Contributor Author

lhl commented Jul 26, 2016

OK, if you merge this pull request it will get you most of the way there.

@danpaquin
Copy link
Owner

Thanks again, I would like to add the rest of the files I need later this week and then merge once it's ready to be updated.

@lhl
Copy link
Contributor Author

lhl commented Jul 26, 2016

OK, it might be better to merge now since this pull request I think is applying master to master. I am checking in changes to make this Python 3 compatible...

@danpaquin
Copy link
Owner

Would it also require that I add brackets to the print statements?

@lhl
Copy link
Contributor Author

lhl commented Jul 26, 2016

Well, depends on if I get to it first or not I guess. It'd be better to merge these non-conflicting changes first, will make life easier for the other changes that will probably be a bit more invasive. My plan is to make changes over the next day or two...

@danpaquin danpaquin merged commit a0fc2b9 into danpaquin:master Jul 27, 2016
danpaquin pushed a commit that referenced this pull request Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants