-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(#7375): fix dependency issues #7394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
add mapping since jest doesn't understand import maps
Update: The PR now also addresses the CSS issue by using babel-plugin-inline-import to inline the CSS. |
Update: I noticed that the ESM code generated by babel contains a lot of unnecessary transforms that are not required in an ESM environment. I therefore updated the babel config to only use the non-standard plugins. |
Hey @martinjagodic - could you please re-review this PR? 🙏🙏🙏 |
Summary
This PR addresses several dependency-related issues identified in #7375:
slate-hyperscript
from a dev dependency into a runtime dependency ofdecap-cms-widget-markdown
clean-stack
to v5.2.0 indecap-cms-core
react-scroll-sync
to v0.11.2 indecap-cms-core
This PR does not address the CSS import issue. Simply removing the imports would break the pre-build scripts, where these imports are resolved by webpack.
Test plan
Verified that the following issues are resolved:
slate-hyperscript
resolution errorclean-stack
browser compatibility error (os is not defined
)react-scroll-sync
Checklist
A picture of a cute animal
🐼