fix(7281): remove the string "DRAFT_MEDIA_FILES" #7432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently blocking me. Would love to see it merged. 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #7281.
I simply removed the string
DRAFT_MEDIA_FILESfrom the return value ofselectMediaFolderand the issue disappeared.I have no idea why this string existed in the first place, but i highly advise that someone with more insight takes a look at this PR in case it breaks anything.
Test plan
I updated the corresponding test to reflect how i think this should work.
npm run testdoesn't show any failures.Checklist
Please add a
xinside each checkbox: