-
-
Notifications
You must be signed in to change notification settings - Fork 181
Issues from Accessibility audit #4743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
ftr, scan was done by https://ngi.aimsites.nl/quickscan/ |
There is aria-haspopup that allows developers and content creators to help screen reader users to identify shift+F10 context sensitive menus and other popups. So when aria-haspopup="menu" is set on a button, on a tab control, on a list item I think it's pretty natural experience to do a thing when pressing the enter key or the space key and popup the menu when pressing F10 key.
I'd recommend sticking with logical keyboard navigation i.e. navigating with tab and shift+tab the way you are doing now and keyboard shortcuts e.g. ctrl+m for focusing message input. Skip links are better suited for web portals where the placement of main content may not always be predictable. Also with that comes another recommendation consider not to move focus as a result of chat state and / or notifications. For example I am chatting in a busy group conversation, I'm trying to type in my message but other group members are exchanging messages and each new message steals my focus from the chat input... That would be complicated. Then perhaps consider adding a keyboard shortcuts that will move focus to the chat log similar how ctrl+m focuses chat input. Or perhaps the fact shift+tab moves from chat input to the chat log is enough. Thanks again for such dedication to screen reader accessibility. If you think it might be usefull to you feel free to get in touch and I'd be happy to try thinking on these and other points you might have from my perspective with you. Greetings Peter |
Thank you so much @pvagner, this is really valuable! |
Ah thanks. |
Regarding the second audit: I contacted HAN Accessibility Lab again and they said it's OK for them to performed after the Tauri project has ended. |
This is mostly to address an accessibility issue where screen reader users are not notified of incoming messages. Applying `aria-live` to the MessageList and thus announcing every message's text is something that requires a lot of consideration. So let's settle on this simple solution for now instead. When you hear the sound, you know that it's time to focus the message list to go through the messages. See - #4743. - #4692. The new setting to control the volume of the sound is also present on Delta Chat Android, except that it's only an on-off toggle.
This is mostly to address an accessibility issue where screen reader users are not notified of incoming messages. Applying `aria-live` to the MessageList and thus announcing every message's text is something that requires a lot of consideration. So let's settle on this simple solution for now instead. When you hear the sound, you know that it's time to focus the message list to go through the messages. See - #4743. - #4692. The new setting to control the volume of the sound is also present on Delta Chat Android, except that it's only an on-off toggle.
This is mostly to address an accessibility issue where screen reader users are not notified of incoming messages. Applying `aria-live` to the MessageList and thus announcing every message's text is something that requires a lot of consideration. So let's settle on this simple solution for now instead. When you hear the sound, you know that it's time to focus the message list to go through the messages. See - #4743. - #4692. The new setting to control the volume of the sound is also present on Delta Chat Android, except that it's only an on-off toggle.
Uh oh!
There was an error while loading. Please reload this page.
We recently got an accessibility quick scan from HAN. They took some time to discuss/test the app with us in a call and gave us a report. treefit and wofwca also made notes during the call, this issues combines points from our notes and the report they gave us. The order is roughly chronological based on the call. (might make sense to reorder and group it into areas of concern, later).
aria-label
for unread count #4655)aria-hidden="true"
for some avatars #4661They use "roving tabindex", which was the case when the audit was performed. Maybe they expected "Tab" to work there. Should we remove roving tabindex?
Edit: also see Move gallery to a dialog, instead of it being a tab #5074
<time>
tag2025-04-21 improvement: a11y don't announce "padlock" on msgs #4659 removed the padlock
rem
that is more flexible than zoom levels: Adjust global font size #890unclear
might need clarification/investigation to be actionable
Dialogs, close button should be inside of form? legend fieldset
What is the situation with context menus how can you trigger them / announce them without mouse?
new message is not announced
Edit: feat: play sound on incoming msg in current chat #5143.
However, for non-current chat of the current account we still need something else: we don't show notifications for the current account's new messages when the window is in focus.
2025-05-23 improvement: notify on msg in all non-curr chats #5146 will fix this.
In the chat, when you get a message, it's also not announced
Screenreader does not announce that it is successfully sent (aria implementation?)
aria-live
for message status #5021 should address this, somewhat at least.encryption info is not interesting in guaranteed e2e encrypted chats, because there are info messages about the chat's state?
But still, the QR should maybe more somewhere else because it related to your own profile
"Bypass block"-options are missing that could allow users to navigate the application more efficiently using a keyboard or screen reader. Please consider implementing “skiplinks” in strategic locations. 2.4.1 Bypass blocks
General / other:
Other findings:
<time>
-element is missing for timestamps, which can cause inconsistent (time-based) announcements.useful links:
http://www.w3.org/TR/WCAG22
The text was updated successfully, but these errors were encountered: