Skip to content

fix(jupyter): keep running event loop when waiting for messages #26049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2024
Merged

fix(jupyter): keep running event loop when waiting for messages #26049

merged 4 commits into from
Oct 9, 2024

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Oct 7, 2024 •
edited
Loading

Closes #24421

@bartlomieju
Copy link
Member Author

bartlomieju commented Oct 8, 2024 •
edited
Loading

Confirmed that it fixes the actual problem. Writing a test for this one might be somewhat challenging, but I'll give it a go.

@bartlomieju bartlomieju requested a review from nathanwhit October 8, 2024 14:39
@bartlomieju bartlomieju changed the title fix(jupyter): keep running event loop [WIP] fix(jupyter): keep running event loop when waiting for messages Oct 8, 2024
nathanwhit
nathanwhit approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 0dfd333 into denoland:main Oct 9, 2024
17 checks passed
@bartlomieju bartlomieju deleted the fix_jupyter_event_loop branch October 9, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@nathanwhit nathanwhit nathanwhit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't make requests to Deno.serve in Jupyter from outside of notebook context
3 participants
@bartlomieju @marvinhagemeister @nathanwhit