fix(serve): support serve hmr #26078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
reviewed
Oct 9, 2024
cli/worker.rs
Outdated
| @@ -415,7 +414,7 @@ impl CliMainWorker { | |||
|
|
|||
| #[derive(Clone)] | |||
| pub struct CliMainWorkerFactory { | |||
| shared: Arc<SharedWorkerState>, | |||
| pub shared: Arc<SharedWorkerState>, | |||
There was a problem hiding this comment.
Are these visibility changes needed?
There was a problem hiding this comment.
No not at all, I used that while inspecting, I'll remove it soon.
bartlomieju
reviewed
Oct 9, 2024
cli/tools/serve.rs
Outdated
Comment on lines
49
to
52
| .unwrap_or(WatchFlagsWithPaths { | ||
| hmr: false, | ||
| ..Default::default() | ||
| }) |
There was a problem hiding this comment.
Suggested change
| .unwrap_or(WatchFlagsWithPaths { | |
| hmr: false, | |
| ..Default::default() | |
| }) | |
| .map(|watch_flags| watch_flags.hmr).unwrap_or(false) |
bartlomieju
reviewed
Oct 13, 2024
cli/worker.rs
Outdated
| @@ -121,7 +121,6 @@ pub struct CliMainWorkerOptions { | |||
| pub serve_port: Option<u16>, | |||
| pub serve_host: Option<String>, | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Can you please revert this line?
There was a problem hiding this comment.
Looks like this hasn't been reverted yet
bartlomieju
reviewed
Oct 13, 2024
There was a problem hiding this comment.
@nathanwhit please take a look. I'm not sure this actually helps much - looks like HMR runner is still not wired up properly
|
@nathanwhit |
|
Aside from that one whitespace change that should be reverted, LGTM |
bartlomieju
pushed a commit
that referenced
this pull request
Nov 5, 2024
This PR addresses issue #25600 Changes: Updated `fn has_hmr` to check `serve` subcommand and return its hmr value if found, in order to run the worker in serve mode with hmr_runner. Thus the hmr event can be dispatched upon changes on the file served.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #25600
Changes:
Updated
fn has_hmrto checkservesubcommand and return its hmr value if found, in order to run the worker in serve mode with hmr_runner. Thus the hmr event can be dispatched upon changes on the file served.