Skip to content

fix(cli): named export takes precedence over default export in doc testing #26112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

magurotuna
Copy link
Member

This commit fixes the issue of import name conflict in case the named export and default export have the same name by letting named export take precedence over default export.

Fixes #26009

Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice tests!

Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@magurotuna magurotuna merged commit 9f0a447 into denoland:main Oct 15, 2024
17 checks passed
@magurotuna magurotuna deleted the magurotuna/named-export-default-export-conflict branch October 15, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno test --doc: test don't compile if a named export is also the default export
3 participants