feat(unstable): --unstable-detect-cjs for respecting explicit "type": "commonjs"
#26149
Conversation
dsherret
changed the title
"type": "commonjs"--unstable-cjs-detection flag for respecting explicit "type": "commonjs"
dsherret
changed the title
--unstable-cjs-detection flag for respecting explicit "type": "commonjs"--unstable-cjs-detection for respecting explicit "type": "commonjs"
cli/args/flags.rs
Outdated
| } else if self.idx > 3 { | ||
| let granular_flag = crate::UNSTABLE_GRANULAR_FLAGS.get(self.idx - 4)?; | ||
| } else if self.idx > 4 { | ||
| let granular_flag = crate::UNSTABLE_GRANULAR_FLAGS.get(self.idx - 5)?; |
There was a problem hiding this comment.
Would be better if the code didn't require changing numbers like this.
There was a problem hiding this comment.
this could just be an else case instead, though the subtraction can't be avoided
There was a problem hiding this comment.
There is already an Why do we do this instead of just constructing a vector or pushing to a command?else.
There was a problem hiding this comment.
I removed this code in fdbb7a4
dsherret
changed the title
--unstable-cjs-detection for respecting explicit "type": "commonjs"--unstable-detect-cjs for respecting explicit "type": "commonjs"
cli/args/flags.rs
Outdated
| Arg::new("unstable-detect-cjs") | ||
| .long("unstable-detect-cjs") | ||
| .help("Reads the package.json type field in a project to treat .js files as .cjs") | ||
| .env("DENO_UNSTABLE_PACKAGE_JSON_TYPE") |
There was a problem hiding this comment.
Do we really need it? Is it used only for testing? If so, maybe we should handle it manually so it doesn't show up in --help output?
There was a problem hiding this comment.
Oops, this should be the new name, but also I don't think we should bother with these env vars. It probably hurts startup time and I bet nobody uses it.
There was a problem hiding this comment.
I agree, let's remove it then.
I'll add a message to say it's not supported in deno compile (right now it will crash in most cases). |
Sounds good. |
When using the
--unstable-detect-cjsflag or adding"unstable": ["detect-cjs"]to a deno.json, it will make a JS file CJS if the closest package.json contains"type": "commonjs"and the file is not an ESM module (no TLA, noimport.meta, noimport/export).--unstable-detect-cjstracking issue #26225