fix(install): better json editing #26450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Oct 21, 2024
bartlomieju
reviewed
Oct 21, 2024
Comment on lines
+82
to
+83
| fn contents(&self) -> String { | ||
| self.cst.to_string() |
There was a problem hiding this comment.
Does it need to be accessed more than one time? If not, consider making it consume self to better communicate that?
There was a problem hiding this comment.
self.path is still used after this.
bartlomieju
reviewed
Oct 21, 2024
bartlomieju
reviewed
Oct 21, 2024
| let deps_prop = self.root_object.get("dependencies"); | ||
| let dev_deps_prop = self.root_object.get("devDependencies"); | ||
|
|
||
| let dependencies = if dev { |
There was a problem hiding this comment.
Will this still remove the entry from the other "dependencies" when inserting it?
Ie. will deno install npm:foo and then deno install --dev npm:foo leave only a single entry and not entry in both dependencies and devDependencies?
bartlomieju
reviewed
Oct 21, 2024
| path: PathBuf, | ||
| modified: bool, | ||
| } | ||
| if let Some(other) = other_dependencies { |
There was a problem hiding this comment.
Oh I see now that it will 👍
bartlomieju
approved these changes
Oct 21, 2024
bartlomieju
pushed a commit
that referenced
this pull request
Oct 25, 2024
1. Respects the formatting of the file (ex. keeps four space indents or tabs). 2. Handles editing of comments. 3. Handles trailing commas. 4. Code is easier to maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.