Skip to content

fix(install): update lockfile when using package.json #26458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Oct 21, 2024

This commit makes sure that deno add, deno install and deno remove update
the lockfile if only package.json file is present.

Fixes #26270

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@bartlomieju bartlomieju merged commit 67280f8 into denoland:main Oct 21, 2024
17 checks passed
@bartlomieju bartlomieju deleted the update_lockfile_if_package_json branch October 21, 2024 23:08
bartlomieju added a commit that referenced this pull request Oct 25, 2024
This commit makes sure that `deno add`, `deno install` and `deno remove`
update the lockfile if only `package.json` file is present.

Fixes #26270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno install <pkg> doesn't update lockfile when only using package.json
2 participants